[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec dsputil.c, 1.124, 1.125 h264.c, 1.149, 1.150 indeo2.c, 1.5, 1.6 motion_est.c, 1.108, 1.109 mpeg12.c, 1.241, 1.242 mpegvideo.c, 1.487, 1.488 ulti.c, 1.2, 1.3 vp3.c, 1.68, 1.69 vp3dsp.c, 1.5, 1.6

[Michel Bardiaux]

M?ns Rullg?rd wrote:
> Rich Felker <dalias at aerifal.cx> writes:
> 
> 
>>On Sun, Aug 14, 2005 at 05:42:44PM +0200, M?ns Rullg?rd CVS wrote:
>>
>>>Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
>>>In directory mail:/var2/tmp/cvs-serv30264/libavcodec
>>>
>>>Modified Files:
>>>	dsputil.c h264.c indeo2.c motion_est.c mpeg12.c mpegvideo.c 
>>>	ulti.c vp3.c vp3dsp.c 
>>>Log Message:
>>>kill a bunch of compiler warnings
>>
>>Just to be safe: are you sure all these changes are correct? Blindly
>>changing things to make warnings go away can mask problems, so it
>>would be nice to know that you actually checked all of these.
> 
> 
> Is removing unused variables ever unsafe? 

A common gotcha with 'unused' variables is when they are used in 
conditional code.

> Or adding a const keyword
> to make the compiler happy?
> 


-- 
Michel Bardiaux
R&D Director
MediaXim S.A.  Bd. du Souverain, 191  B-1160 Bruxelles
Tel : +32 2 790.29.41