[Ffmpeg-cvslog] r7238 - in trunk/libavutil: common.h internal.h

[Måns Rullgård]

Reimar D?ffinger said:
> Hello,
> On Thu, Dec 07, 2006 at 10:42:34AM -0000, M?ns Rullg?rd wrote:
>> Reimar D?ffinger said:
>> > On Wed, Dec 06, 2006 at 10:27:08PM +0100, mru wrote:
>> >> Author: mru
>> >> Date: Wed Dec  6 22:27:08 2006
>> >> New Revision: 7238
>> >>
>> >> Modified:
>> >>    trunk/libavutil/common.h
>> >>    trunk/libavutil/internal.h
>> >>
>> >> Log:
>> >> move some __attribute__ macros to internal.h
>> >
>> > The problem I have with this is that it makes e.g. bswap.h completely
>> > unusable for external programs unless they define always_inline
>> > themselves.
>>
>> bswap.h isn't installed, so external programs can't use it anyway.
>
> Any program that includes its own copy of libavutil can. And given how
> often keeping your own copy was mentioned as the recommended way of
> using ffmpeg...

Recommended by whom?

> Anyway, without at least some kind of fallback, this means that
> always_inline can never be used for any exported function. So at least
> in the long term this solution does not seem more like a solution to me
> than the old code was.

libavutil never officially defined always_inline, so apps shouldn't have been
relying on it in the first place.  MPlayer is no special case.

-- 
M?ns Rullg?rd
mru at inprovide.com