[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec qdm2.c,1.7,1.8

[Alexander Strasser]

M?ns Rullg?rd wrote:
> Alexander Strasser <eclipse7 at gmx.net> writes:
> > M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Tue, Jan 31, 2006 at 11:02:03PM +0100, Alexander Strasser wrote:
> >> >> M?ns Rullg?rd CVS wrote:
> >> >> > 
> >> >> > Modified Files:
> >> >> > 	qdm2.c 
> >> >> > Log Message:
> >> >> > add static keyword to some functions
> >> >> > patch by Dieter <freebsd at sopwith solgatos com>
> >> >> > 
> >> >> > --- qdm2.c	14 Jan 2006 15:00:10 -0000	1.7
> >> >> > +++ qdm2.c	30 Jan 2006 23:41:27 -0000	1.8
> >> >> > @@ -230,7 +230,7 @@
> >> >> >  static MPA_INT mpa_window[512] __attribute__((aligned(16)));
> >> >> >  
> >> >> >  
> >> >> > -static void softclip_table_init() {
> >> >> > +static void softclip_table_init(void) {
> >> >> 
> >> >>   I somehow dislike this kind of changes. What does the standard say
> >> >> about this?
> >> 
> >> Defining functions with unspecified arguments is allowed but bad.
> >> With arguments unspecified the compiler can't report an error/warning
> >> if the function is called with incorrect arguments.  What don't you
> >> like about it?
> >
> >   i don't like the syntax - but it's ok if it helps preventing mistakes
> 
> The syntax is perfectly logical.  Void literally means "empty"; an
> empty list of arguments, just like a "void" return type means the
> function returns nothing.

  That's one way you could look at it, but don't you think there
are more ways? Like you specify parameters in the parameter list
and that no specified parameter means no parameters? I find this
also much easier to read. This by the way is also analog to the
way you pass no parameters to a function.
  But as I learned this isn't the case in C, so i already said it
is ok and took back my original concern.

  Alex (beastd)