[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec utils.c, 1.173, 1.174 avcodec.h, 1.455, 1.456

[Michael Niedermayer]

Hi

On Wed, Feb 22, 2006 at 02:32:00PM +0100, Alex Beregszaszi wrote:
> Hi,
> 
> > i dont see any sense in changing the version number when not yet working
> > and as "unused" marked code is changed
> > 
> > but there are a few things iam not entirely happy with
> > * S16 was 0 and is 1 now
> > * SAMPLT_FMT_NONE is -1, somehow i think if we do change S16s value NONE 
> >   should be 0
> 
> S16 is set as default format in utils.c, so this doesnt changes the
> behaviour.

ok, for S16=1, but i still prefer SAMPLT_FMT_NONE=0 then


> 
> > * i see little sense in S24 and U8 currently at least, no codec will use
> >   S24 internally, and for raw we need many more formats, S24 in 
> >   native endian is also not good at all as theres no native S24 on most
> >   CPUs
> 
> all the lossless codecs support 24/32 bits aswell

iam not saying they dont, just that its faster to output 24bit in ints
instead of some "3 bytes per sample" format

[...]

-- 
Michael