[Ffmpeg-cvslog] CVS: CVSROOT style.sh, NONE, 1.1 commitinfo, 1.1, 1.2
Thu Jan 26 23:12:28 CET 2006
On Thu, Jan 26, 2006 at 09:59:39PM +0100, Michael Niedermayer wrote:
> On Thu, Jan 26, 2006 at 09:53:10PM +0100, Diego Biurrun wrote:
> > On Thu, Jan 26, 2006 at 03:30:56PM -0500, Rich Felker wrote:
> > > On Fri, Jan 13, 2006 at 11:10:28AM +0100, Nico Sabbi wrote:
> > > > Alex Beregszaszi wrote:
> > > >
> > > > >>Added Files:
> > > > >> style.sh
> > > > >>Log Message:
> > > > >>Coding style script that prohibits tabs and trailing whitespace.
> > > > >
> > > > >Hey, that's cool :)
> > > > >
> > > > >What about extending the check with other usual mistakes and adding
> > > > >it to the mplayer tree aswell?
> > > >
> > > > I'm against forbidding tabs in mplayer (I use only tabs)
> > >
> > > Me too. Also we use imported or "semi-imported" code (e.g. my
> > > pullup.c) which uses tabs and will not be happy to switch. MPlayer
> > > rule has always been that the maintainer of the file gets to decide
> > > the style, and in the case of my file's it's tabs-only, no-spaces.
> > Anyway, for team projects this is different. A common style guideline
> > would not hurt IMO. By definition this will imply a compromise, in
> > which some parties have to budge.
> > IMO a no-tabs policy is sane for teams. Otherwise you easily get a mix
> > of tabs and spaces even in individual files. This is horrible.
> what about a script which rejects trailing whitespace and tabspace mix
> for mplayer ;)
> or trailing whitespace only?
I'm all for it, but we would have to remove it from the code first in a
series of cosmetic commits. Furthermore with MPlayer we have many more
imported libraries, so the situation is a bit different.
Anyway, this is the wrong place to discuss this, we'd have to move the
thread to mplayer-dev-eng.
More information about the ffmpeg-cvslog