[Ffmpeg-cvslog] Re: r5598 - in trunk: Changelog MAINTAINERS doc/ffmpeg-doc.texi libavformat/Makefile libavformat/allformats.c libavformat/allformats.h libavformat/gxf.c

[Baptiste Coudurier]

Hi

reimar wrote:
> [...]
> +        case 13:
> +        case 15:
> +            st->codec->codec_type = CODEC_TYPE_VIDEO;
> +            st->codec->codec_id = CODEC_ID_DVVIDEO;
> +            st->codec->codec_tag = MKTAG('d', 'v', 'c', ' ');
> +            break;
> +        case 14:
> +        case 16:
> +            st->codec->codec_type = CODEC_TYPE_VIDEO;
> +            st->codec->codec_id = CODEC_ID_DVVIDEO;
> +            st->codec->codec_tag = MKTAG('d', 'v', 'c', 'p');
> +            break;

I don't know if it is "right" to assign those tags to dv50. I suppose
tags are there to help demux_lavf.c to assign correct codecs, am I right
? I know lavc dv decoder can probe dv50 on its own, but still...

Also, would it be better to assign CODEC_ID_NONE and CODEC_TYPE_DATA to
unrecognized streams ? Instead of -1.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312