[Ffmpeg-cvslog] CVS: ffmpeg/libavformat movenc.c,1.80,1.81

[Michael Niedermayer]

Hi

On Fri, May 26, 2006 at 10:48:55PM +0200, Alex Beregszaszi wrote:
> Hi,
>  
> > +        // Encoder
> > +        len = strlen(LIBAVCODEC_IDENT)+1;
> > +        put_be16(pb, len*2+10);             /* size */
> > +        put_be32(pb, 0x04);                 /* type */
> > +        put_be16(pb, language_code("eng")); /* language */
> > +        put_be16(pb, 0x01);                 /* ? */
> > +        ascii_to_wc(pb, LIBAVCODEC_IDENT, len);
> > +        size += len*2+10;
> 
> check for bitexact missing?

yes (though that part is from mobliehackers IIRC)


> 
> > +        // Date
> > +//        snprintf(dt,32,"%04d/%02d/%02d
> > %02d:%02d:%02d",t_st->tm_year+1900,t_st->tm_mon+1,t_st->tm_mday,t_st-
> > >tm_hour,t_st->tm_min,t_st->tm_sec);
> > +        len = strlen("2006/04/01 11:11:11")+1;
> > +        put_be16(pb, len*2+10);    /* size */
> > +        put_be32(pb, 0x03);        /* type */
> > +        put_be16(pb, language_code("und")); /* language */
> > +        put_be16(pb, 0x01);        /* ? */
> > +        ascii_to_wc (pb, "2006/04/01 11:11:11", len);
> > +        size += len*2+10;
> 
> What about adding "paranoid" mode, which disables all timestamp dumps,
> but else it should write correct values. Of course paranoid mode could
> be turned on by default. And I think writing unix epoch would be nicer
> :)

actually i should have used AVFormatContext.timestamp which is set to 0
by default and can be set to the correct time ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is