[Ffmpeg-cvslog] r5422 - trunk/libavcodec/ratecontrol.c

[Corey Hickey]

michael wrote:
> Author: michael
> Date: Mon May 29 18:50:37 2006
> New Revision: 5422
> 
> Modified:
>    trunk/libavcodec/ratecontrol.c
> 
> Log:
> fabs is better then abs for floats ...
> 
> 
> Modified: trunk/libavcodec/ratecontrol.c
> ==============================================================================
> --- trunk/libavcodec/ratecontrol.c	(original)
> +++ trunk/libavcodec/ratecontrol.c	Mon May 29 18:50:37 2006
> @@ -911,7 +911,7 @@
>      av_free(qscale);
>      av_free(blured_qscale);
>  
> -    if(abs(expected_bits/all_available_bits - 1.0) > 0.01 ){
> +    if(fabs(expected_bits/all_available_bits - 1.0) > 0.01 ){
>          av_log(s->avctx, AV_LOG_ERROR, "Error: 2pass curve failed to converge\n");
>          return -1;
>      }

This is resulting in mencoder failing the second pass for me. Prior to
this revision, the same command works fine.


mplayer_20060519/mencoder l.mpg -frames 240 -nosound -ovc lavc -lavcopts
vcodec=mpeg4:vmax_b_frames=2:vbitrate=800:vpass=2 -o /dev/null
MEncoder dev-CVS-20060519-4.0.4 (C) 2000-2006 MPlayer Team
CPU: AMD Athlon(tm) 64 Processor 3400+ (Family: 15, Model: 14, Stepping: 0)
CPUflags: Type: 15 MMX: 1 MMX2: 1 3DNow: 1 3DNow2: 1 SSE: 1 SSE2: 1
Compiled for x86 CPU with extensions: MMX MMX2 3DNow 3DNowEx SSE SSE2

success: format: 0  data: 0x0 - 0x5677df8
MPEG-PS file format detected.
VIDEO:  MPEG1  352x240  (aspect 12)  29.970 fps  1150.0 kbps (143.8 kbyte/s)
[V] filefmt:2  fourcc:0x10000001  size:352x240  fps:29.97  ftime:=0.0334
Opening video filter: [expand osd=1]
Expand: -1 x -1, -1 ; -1, osd: 1, aspect: 0.000000, round: 1
==========================================================================
Opening video decoder: [mpegpes] MPEG 1/2 Video passthrough
VDec: vo config request - 352 x 240 (preferred colorspace: Mpeg PES)
Could not find matching colorspace - retrying with -vf scale...
Opening video filter: [scale]
The selected video_out device is incompatible with this codec.
Try adding the scale filter, e.g. -vf spp,scale instead of -vf spp.
VDecoder init failed :(
Opening video decoder: [libmpeg2] MPEG 1/2 Video decoder libmpeg2-v0.4.0b
Selected video codec: [mpeg12] vfm: libmpeg2 (MPEG-1 or 2 (libmpeg2))
==========================================================================
VDec: vo config request - 352 x 240 (preferred colorspace: Planar YV12)
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 1.30:1 - prescaling to correct movie aspect.
videocodec: libavcodec (352x240 fourcc=34504d46 [FMP4])
[mpeg4 @ 0xb54e50]Error: 2pass curve failed to converge
Could not open codec.
FATAL: Cannot initialize video driver.

Exiting...


-Corey