[Ffmpeg-cvslog] r6673 - trunk/libavcodec/h264.c

[Michael Niedermayer]

Hi

On Thu, Oct 12, 2006 at 08:29:46PM +0300, Uoti Urpala wrote:
> On Thu, 2006-10-12 at 14:27 +0200, michael wrote:
> > +++ trunk/libavcodec/h264.c	Thu Oct 12 14:27:02 2006
> 
> > -    static const int significant_coeff_flag_offset_8x8[2][63] = {
> > +    static const uint8_t significant_coeff_flag_offset_8x8[2][63] = {
> 
> The line
>         const int *sig_off = significant_coeff_flag_offset_8x8[MB_FIELD];
> was left unchanged, causing a segfault on my machine.

sorry, ill fix it in a minute


> 
> (Did you already change that to uint8_t locally and forget to commit? 

no


> I
> don't see how that could possibly work on any machine, and you posted
> benchmark results for another change later.)

this code is only used for 8x8 dct my testfile apparently doensnt use 8x8
dct ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is