[Ffmpeg-cvslog] r6149 - trunk/libavcodec/snow.c

Loren Merritt lorenm
Sat Sep 2 01:19:39 CEST 2006

On Sat, 2 Sep 2006, Oded Shimon wrote:

> On Sat, Sep 02, 2006 at 12:02:39AM +0200, lorenm wrote:
>> snow cosmetics: merge the sliced and non-sliced versions of add_yblock
>> +static always_inline void add_yblock(SnowContext *s, int sliced, slice_buffer *sb, DWTELEM *dst, uint8_t *dst8, const uint8_t *obmc, int src_x, int src_y, int b_w, int b_h, int w, int h, int dst_stride, int src_stride, int obmc_stride, int b_x, int b_y, int add, int offset_dst, int plane_index){
>> [..]
>> +        if(!sliced && !offset_dst)
> Personally I would just use a NULL check on 'sb' to tell between sliced
> and non sliced versions instead of adding a param...

Then the inliner can't optimize away the check.

--Loren Merritt

More information about the ffmpeg-cvslog mailing list