[Ffmpeg-cvslog] r7537 - trunk/libavformat/avidec.c

Diego Biurrun diego
Tue Jan 16 23:32:13 CET 2007


On Tue, Jan 16, 2007 at 12:49:31AM +0100, Michael Niedermayer wrote:
> 
> On Tue, Jan 16, 2007 at 12:12:15AM +0100, Guillaume POIRIER wrote:
> > 
> > On 1/15/07, michael <subversion at mplayerhq.hu> wrote:
> > 
> > >fixing segfault with http://sam.zoy.org/zzuf/lol-ffplay.avi
> > 
> > >--- trunk/libavformat/avidec.c  (original)
> > >+++ trunk/libavformat/avidec.c  Mon Jan 15 23:56:46 2007
> > >@@ -397,7 +397,7 @@
> > >-            if (stream_index >= s->nb_streams || avi->dv_demux) {
> > >+            if (stream_index >= (unsigned)s->nb_streams || avi->dv_demux) 
> > 
> > That's interesting: why this fix instead of defining nb_streams struct
> > member as unsigned int?
> > 
> > Wouldn't that be more logical?
> 
> hmm maybe, feel free to change it to unsigned ... (dont forget the regression
> tests)

Done, regression tests passsed.

Diego





More information about the ffmpeg-cvslog mailing list