[FFmpeg-cvslog] r9345 - in trunk: libavcodec/armv4l/mathops.h libavcodec/atrac3data.h libavcodec/bethsoftvideo.h libavcodec/bmp.h libavcodec/cavsdata.h libavcodec/cookdata.h libavcodec/dca.h libavcodec/dcadata.h libavcodec/dcahuff.h libavcodec/dn

[Guillaume POIRIER]

Hi,

On 6/17/07, mru <subversion at mplayerhq.hu> wrote:
> Author: mru
> Date: Sun Jun 17 02:01:30 2007
> New Revision: 9345
>
> Log:
> add multiple inclusion guards to headers

[..]

> Modified: trunk/libavcodec/armv4l/mathops.h
> ==============================================================================
> --- trunk/libavcodec/armv4l/mathops.h   (original)
> +++ trunk/libavcodec/armv4l/mathops.h   Sun Jun 17 02:01:30 2007
> @@ -19,6 +19,9 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
>
> +#ifndef AVCODEC_ARM_MATHOPS_H
> +#define AVCODEC_ARM_MATHOPS_H
> +
>  #ifdef FRAC_BITS
>  #   define MULL(a, b) \
>          ({  int lo, hi;\
> @@ -47,3 +50,5 @@
>           __rt; })
>
>  #endif
> +
> +#endif

May I suggest that these #endif have a comment telling which #if they
refer to? Of course, in this case, all #endif are at the last
preprocessor directive of the file, so it's easy figure this out; I
however think it's one of this cheap best practices that avoids
introducing bugs by mistake.

Just my 0,02 ?.

Guillaume
-- 
Subversion has been the most pointless project ever started
  -- Linus Torvalds