[Ffmpeg-cvslog] r8204 - trunk/libavformat/mov.c

Michael Niedermayer michaelni
Sat Mar 3 22:16:55 CET 2007


On Sat, Mar 03, 2007 at 04:00:08PM -0500, The Wanderer wrote:
> Michael Niedermayer wrote:
> >Hi
> >
> >On Sat, Mar 03, 2007 at 08:48:35PM +0100, Baptiste Coudurier wrote:
> >>You going to revert it for 2 lines of fourccs even more when those
> >>2 lines are mentioned in the commit log ?
> >
> >yes
> <snip>
> >btw, i didnt even realize that its 2 lines and that exactly is the
> >problem with such commits you never know what really has been changed
> >if cosmetics get mixed with functional changes
> I read through the patch looking for the change described, to make sure
> I wasn't incorrect before posting, and I was unable to even tell with
> certainty (in a reasonable amount of time) which lines contained the new
> tags - because the table was also being rearranged by the same commit.
> As a result, I was unable to be sure whether or not a non-cosmetic
> change had been made.
> This is part of the reason for the rule against mixing functional and
> cosmetic changes, and part the reason for the rule against mixing
> unrelated changes: it makes reading the patch to find a particular
> change harder. (It also means that if one change ever needs to be
> reverted, it is significantly harder to do so without also reverting any
> others which were in the same patch.)

ive fixed the mess, ive also found that WMV3 was removed in the change
which the commit message had not mentioned and baptiste apparently forgot

baptiste please be more carefull in the future

btw why was WMV3 removed?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070303/f4a742af/attachment.pgp>

More information about the ffmpeg-cvslog mailing list