[Ffmpeg-cvslog] r8204 - trunk/libavformat/mov.c
Sat Mar 3 22:44:10 CET 2007
Michael Niedermayer wrote:
> On Sat, Mar 03, 2007 at 04:00:08PM -0500, The Wanderer wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Mar 03, 2007 at 08:48:35PM +0100, Baptiste Coudurier wrote:
>>>> You going to revert it for 2 lines of fourccs even more when those
>>>> 2 lines are mentioned in the commit log ?
>>> btw, i didnt even realize that its 2 lines and that exactly is the
>>> problem with such commits you never know what really has been changed
>>> if cosmetics get mixed with functional changes
>> I read through the patch looking for the change described, to make sure
>> I wasn't incorrect before posting, and I was unable to even tell with
>> certainty (in a reasonable amount of time) which lines contained the new
>> tags - because the table was also being rearranged by the same commit.
>> As a result, I was unable to be sure whether or not a non-cosmetic
>> change had been made.
>> This is part of the reason for the rule against mixing functional and
>> cosmetic changes, and part the reason for the rule against mixing
>> unrelated changes: it makes reading the patch to find a particular
>> change harder. (It also means that if one change ever needs to be
>> reverted, it is significantly harder to do so without also reverting any
>> others which were in the same patch.)
Like if you would ever patch something buggy. Let's talk about
meritocracy a bit, like someone suggested ?
> ive fixed the mess, ive also found that WMV3 was removed in the change
> which the commit message had not mentioned and baptiste apparently forgot
> baptiste please be more carefull in the future
Well, for sure, I won't clean any mess in the future. Yes im quite
upset, and tired.
> btw why was WMV3 removed?
cleanup, wmv3 is not needed since vc1 fourcc will pick up CODEC_ID_VC1
for demuxing first, and never wmv3.
Note that technically, adding those codec FOURCCs had absolutely no
effect on the code, since BE codec id would have been chosen first.
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A. http://www.smartjog.com
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
More information about the ffmpeg-cvslog