[FFmpeg-cvslog] r8916 - in trunk/libavcodec: vc1.c vc1data.c vc1data.h
Sun May 6 18:35:16 CEST 2007
On Sun, May 06, 2007 at 03:06:17PM +0200, matthieu castet wrote:
> Michael Niedermayer wrote:
> > On Sun, May 06, 2007 at 01:40:42PM +0200, kostya wrote:
> > a vc1_ prefix is insufficient for global variables, they should have
> > a ffmpeg/libavcodec specific prefix, that is ff_ for internal variables
> > a prefix like vc1_ or ac3_ would not prevent name clashes with other
> > implementations of the same codec and such other implementations are the
> > most likely things where name clashes would occur ...
> As for better modularity more and more static variables become global.
> Couldn't we introduce a __attribute__visibility_hiden for the compilers
> that support it ?
1. __* is resereved
2. the default should be hidden and you should rather mark the public
variables if you do this at all
3. all variables except thouse in public headers should be hidden
so adding hidden/vissible fields to each var is nonsense it should
be per header rather
> That way we could avoid some symbol clashes.
> Of course the variable should still prefixed
these 2 lines contradict each other
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-cvslog