[FFmpeg-cvslog] r10930 - trunk/libavformat/rtp.c

[Luca Abeni]

Hi Michael,

first of all, thanks for the feedback.

Michael Niedermayer wrote:
>> Log:
>> Do not send too many RTCP packets (according to the RFC, the minimum
>> distance between two consecutive RTCP packets is 5s)
>>
>>
>> Modified:
>>    trunk/libavformat/rtp.c
[...]
> if your goal is to prevent 2 packets from hitting the other computer within
> 5sec then it might be better to use a value larger then 5sec

I think I wrote a bad commit message: according to the RFC, 5sec is the minimum
RTCP transmission interval, not the minimum distance expected by the receiver
(and I suspect it is not a "hard" limit... But the previous code in rtp.c was
generating more than 100 RTCP packets per second).
I'll update the commit message this evening or tomorrow morning.

Anyway, now our current code does the same thing as the example code in the RFC
(our code is much simpler because we do not consider multiple clients, but the
minimum interval is enforced in the same way).


> just think what happens if one packet gets delayed by 500ms

You mean, if the packet is actually sent by the kernel 500ms after ffmpeg performs
the sendto()?
In this case, you are right: the distance between two packets will be less than
5sec.
But the code in RFC3550 (Appendix A.7) has the same problem, so I think we can
safely ignore it ;-)



			Thanks,
				Luca