[FFmpeg-cvslog] r12759 - in trunk/libavcodec: aac_ac3_parser.c aac_ac3_parser.h aac_parser.c ac3_parser.c
Thu Apr 10 01:00:03 CEST 2008
On ?roda, 9 kwietnia 2008, Michael Niedermayer wrote:
> 1. the demuxer seems buggy its output with seeking and normal linear
> playback differs. A fix for this MUST be in the demuxer.
> 2. your frame_in_buffer code is buggy, it causes random number of parsed
> bytes to be returned.
> Hint you cannot change buf_size.
> 3. why is need_next_header set for AC-3 ?
> 4. The return value of ff_combine_frame is ignored. This causes at least a
> lost packet at EOF.
> I suspect that the best course of action is to revert the changes up to the
> point where the regression tests pass again.
> Next the rm demuxer must be fixed which will likely change the regression
> checksums, which need to be updated after confirming that the rm demuxer
> works equally well or better.
> And last the parser should be commited again. (but of course only if
> regressions pass, if they dont the bugs causing the failure must be found
> and fixed similar to the rm demxuer _before_ commiting the parser)
1.I'm totally disorientated in this code, so I think that maybe someone else
shold get it?
3. Justin wrote, that it's correct and applied in Blu-ray
( http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/2008-March/003009.html )
? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?
2. 4. Ok, I'll fix it.
I undo changes in aac_ac3_parser, aac_parser and ac3_parser. Should I fix rm
or maybe someone else will do it?
More information about the ffmpeg-cvslog