[FFmpeg-cvslog] r12858 - trunk/libavcodec/nellymoserdec.c

[Michael Niedermayer]

On Wed, Apr 16, 2008 at 11:55:56PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Wed, Apr 16, 2008 at 10:44:02PM +0200, Diego Biurrun wrote:
> >> On Wed, Apr 16, 2008 at 05:33:09PM +0200, michael wrote:
> >> > 
> >> > Log:
> >> > cosmetic
> >> > 
> >> > --- trunk/libavcodec/nellymoserdec.c	(original)
> >> > +++ trunk/libavcodec/nellymoserdec.c	Wed Apr 16 17:33:09 2008
> >> > @@ -120,7 +120,8 @@ static void overlap_and_window(NellyMose
> >> >  
> >> >      while (bot < NELLY_BUF_LEN) {
> >> > -        audio[bot] = a_in[bot]*sine_window[bot]+state[bot]*sine_window[top] + s->add_bias;
> >> > +        audio[bot] = a_in [bot]*sine_window[bot]
> >> > +                    +state[bot]*sine_window[top] + s->add_bias;
> >> 
> >> Is it just me or could this code use some spacing around operators?
> >
> > Must be just you, it looks fine to me.
> 
> I'm with Diego on this one.

Well, the real question is what the maintainer of the file prefers.
I was just cleaning the transform&windowing up so we know what we are
dealing with for a possible gsoc nelly encoder.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080417/e823ceb3/attachment.pgp>