[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Måns Rullgård]

Michael Niedermayer wrote:
> On Fri, Aug 01, 2008 at 09:39:16AM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>>
>> > The only reason why its not causing a problem is plain because its not
>> > done, our headers luckily do in general not include all the headers they
>> > somehow depend on.
>>
>> Actually, *all* our headers #include their dependencies.  That's what
>> "make checkheaders" makes sure.
>
> avcodec.h does not include inttypes or stdint directly but use int64_t
> and iam sure it would be easier to find headers missing dependencies
> than ones listing all.

avcodec.h includes common.h, which does include stdint.h.  As I said,
common.h is a special case.  Its purpose is to avoid duplicating
code that would have to be in practically every file otherwise, and
this includes including stdint.h.

Now please stop trolling, and get back to coding, which you do very well.
Quite frankly though, I doubt you have the experience necessary to for
an informed opinion on organisational matters like these.  That a certain
method can, if enough force is applied, achieve a working end result,
does not in any way whatsoever make it a good method.

-- 
M?ns Rullg?rd
mans at mansr.com