[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Sat, Aug 02, 2008 at 02:50:40PM +0200, Diego Biurrun wrote:
> On Sat, Aug 02, 2008 at 04:25:52AM +0200, Michael Niedermayer wrote:
> > On Sat, Aug 02, 2008 at 04:09:47AM +0200, Michael Niedermayer wrote:
> > > 
> > > currently audioconvert.h needs the audio sample format enum and
> > > audioconvert.c needs it too, and its provided by avcodec.h
> > > after a 5 sec look, audioconvert.c also use av_free() and uint8_t
> > > at that point one can start a long discussion if stdint.h and mem.h should be
> > > included or avcodec.h or nothing or all 3.
> > 
> > after a little longer ;)
> > 
> > it also uses lrintf & snprintf thus also needs one way or another
> > stdio.h and math.h with  _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE defined before
> > inclusion of math.h
> 
> These definitions are part of the global CFLAGS, no need to duplicate
> them.

until it causes you an hour of work when you try to compile it
in mplayer that happenes not to set them.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080802/7de9ccca/attachment.pgp>