[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Uoti Urpala]

On Sat, 2008-08-02 at 17:23 +0200, Michael Niedermayer wrote:
> On Sat, Aug 02, 2008 at 02:50:40PM +0200, Diego Biurrun wrote:
> > On Sat, Aug 02, 2008 at 04:25:52AM +0200, Michael Niedermayer wrote:
> > > it also uses lrintf & snprintf thus also needs one way or another
> > > stdio.h and math.h with  _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE defined before
> > > inclusion of math.h

Those are standard C, so any special defines are only required if the
default is to use old versions.

> > These definitions are part of the global CFLAGS, no need to duplicate
> > them.
> 
> until it causes you an hour of work when you try to compile it
> in mplayer that happenes not to set them.

MPlayer uses -std=gnu99 with GCC, so no extra defines are needed for
standard C functions. So even if such defines are not set any problems
could only occur if you're using some compiler which MPlayer does not
recognize and which does not support C99 functions by default.