[FFmpeg-cvslog] r15029 - trunk/libavcodec/libx264.c

Ramiro Polla ramiro
Sat Aug 30 00:49:34 CEST 2008


stefano wrote:
> Author: stefano
> Date: Fri Aug 29 19:37:32 2008
> New Revision: 15029

Hmmm... I don't usually care about these small things, but this message 
could use some re-wording.

> Log:
> Make X264_init() do not set anymore the rc_eq from avctx to the
> libx264 context.

Diego suggested: Make X264_init() not set rc_eq from avctx to the 
libx264 context anymore.

Is this correct?

 > Fix a crash due to X264_init() setting the libx264
> rc_eq field to NULL when rc_eq was not defined.
> This patch drops the possibility to set the rc_eq for libx264,
> feature which is going to be removed from libx264 either.

This is not the right context to use "either". What about:

This patch drops the possibility to set the rc_eq for libx264, a feature 
which is going to be removed from libx264 too.

or "... from libx264 as well.", or "... which is also going to be 
removed from libx264."?




More information about the ffmpeg-cvslog mailing list