[FFmpeg-cvslog] r16244 - trunk/libavcodec/qcelpdec.c

[Dominik 'Rathann' Mierzejewski]

On Saturday, 20 December 2008 at 19:28, Diego Biurrun wrote:
> On Sat, Dec 20, 2008 at 03:38:35AM +0100, reynaldo wrote:
> > 
> > Log:
> > Cosmetics by Kenan Gillet. Part 1 of 3 of his 'qcelp: silence handling'
> > changeset.
> 
> Ummmm....
> 
> > --- trunk/libavcodec/qcelpdec.c	(original)
> > +++ trunk/libavcodec/qcelpdec.c	Sat Dec 20 03:38:34 2008
> > @@ -536,7 +536,12 @@ static void apply_pitch_filters(QCELPCon
> >          {
> > -            float max_pitch_gain = q->erasure_count < 3 ? 0.9 - 0.3 * (q->erasure_count - 1) : 0.0;
> > +            float max_pitch_gain;
> > +
> > +            if (q->erasure_count < 3)
> > +                max_pitch_gain = 0.9 - 0.3 * (q->erasure_count - 1);
> > +             else
> > +                max_pitch_gain = 0.0;
> 
> ... cosmetics?

The code logic is unchanged. However, this would've been two lines shorter:
-            float max_pitch_gain = q->erasure_count < 3 ? 0.9 - 0.3 * (q->erasure_count - 1) : 0.0;
+            float max_pitch_gain = 0.0;
+
+            if (q->erasure_count < 3)
+                max_pitch_gain = 0.9 - 0.3 * (q->erasure_count - 1);

Regards,
R.

-- 
MPlayer http://mplayerhq.hu | RPMFusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan