[FFmpeg-cvslog] r16378 - in trunk/libavformat: rdt.c rmdec.c

Michael Niedermayer michaelni
Mon Dec 29 01:01:07 CET 2008


On Sun, Dec 28, 2008 at 07:00:22PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Dec 28, 2008 at 6:45 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Mon, Dec 29, 2008 at 12:24:00AM +0100, rbultje wrote:
> >> Modified: trunk/libavformat/rdt.c
> >> ==============================================================================
> >> --- trunk/libavformat/rdt.c   Mon Dec 29 00:12:46 2008        (r16377)
> >> +++ trunk/libavformat/rdt.c   Mon Dec 29 00:23:59 2008        (r16378)
> >> @@ -438,6 +438,7 @@ static void
> >>  rdt_free_extradata (PayloadContext *rdt)
> >>  {
> >>      ff_rm_free_rmstream(rdt->rmst[0]);
> >> +    av_free(rdt->rmst[0]);
> >>      if (rdt->rmctx)
> >>          av_close_input_stream(rdt->rmctx);
> >>      av_freep(&rdt->mlti_data);
> >
> > this really wasnt part of reimars patch
> > besides it should be av_freep(), as its safer ...
> 
> The structure in which the pointer resides (rdt) disappears in the
> same function call, so is av_freep() really needed?

no, sorry, ive missed that
but the name of the function maybe isnt ideal in this case ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081229/75b1eb71/attachment.pgp>



More information about the ffmpeg-cvslog mailing list