[FFmpeg-cvslog] r11815 - trunk/libavformat/asf.c

[Michael Niedermayer]

On Sat, Feb 02, 2008 at 11:57:28PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Sat, Feb 02, 2008 at 11:36:29PM +0100, Michael Niedermayer wrote:
> > And the #ifdef makes the code much more obfuscated. A unused function never
> > points to a bug except by coincidence. It might point to some forgotten old
> > code but not more. Theres attribute(unused) for silencing such warnings.
> 
> well, it's no problem to change it to av_unused, though this whole thing
> IMO raises a few other questions, like what is a CONFIG_MMSH_PROTOCOL
> doing in a demuxer at all.

hmm, ive thought it would be needed, but after looking at the mms patch again
i dont see why it was implemented like that. Feel free to remove the is_mms()
and the case where its used.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080203/fcbd8368/attachment.pgp>