[FFmpeg-cvslog] r11848 - trunk/libavformat/matroskadec.c

Michael Niedermayer michaelni
Mon Feb 4 04:20:03 CET 2008


On Mon, Feb 04, 2008 at 03:36:35AM +0100, Luca Barbato wrote:
> michael wrote:
> > Author: michael
> > Date: Mon Feb  4 02:04:27 2008
> > New Revision: 11848
> > 
> > Log:
> > Remove incorrect cast found by -Wwrite-strings.
> 
> > -                put_buffer(&b, (uint8_t *) "TTA1", 4);
> > +                put_buffer(&b, "TTA1", 4);
> 
> "TTA1" isn't uint8_t, put_buffer accepts const unsigned char
>  (const uint8_t*) would be more correct.

no no no, you dont do it correctly
its:

(void)put_buffer((ByteIOContext *)&b, (const unsigned char*)"TTA1", (int)4);

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080204/d445d21c/attachment.pgp>



More information about the ffmpeg-cvslog mailing list