[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

[Reimar Döffinger]

On Tue, Feb 26, 2008 at 07:50:14PM +0100, Baptiste Coudurier wrote:
> Reimar D?ffinger wrote:
> >> @@ -1451,6 +1529,13 @@ static int mov_read_header(AVFormatConte
> >>          sc->ffindex = i;
> >>          mov_build_index(mov, st);
> >>  
> >> +        if (sc->dref_id-1 < sc->drefs_count && sc->drefs[sc->dref_id-1].path) {
> >> +            if (url_fopen(&sc->pb, sc->drefs[sc->dref_id-1].path, URL_RDONLY) < 0)
> >> +                av_log(s, AV_LOG_ERROR, "stream %d, error opening external essence: %s\n",
> >> +                       st->index, strerror(errno));
> >> +        } else
> >> +            sc->pb = s->pb;
> > 
> > This must be a joke. Or do you seriously consider it acceptable for a
> > demuxer to do url_fopen?!
> 
> Please do not whine. Give valid reasons AND suggest another correct way
> to handle those files.

Like the fact that this probably can be misused to detect whenever
someone plays a locally stored file?
That it breaks layering between demuxers and streams?
It can also only work for applications that either use the stream layer in
libavformat or register their protocols in it.
I do not know what exactly is necessary to handle this correctly, but at
least it would have to be optional.