[FFmpeg-cvslog] r11374 - trunk/libavformat/rmdec.c

Diego Biurrun diego
Sun Jan 6 23:50:35 CET 2008


On Sun, Jan 06, 2008 at 07:20:35PM +0100, Reimar D?ffinger wrote:
> On Thu, Jan 03, 2008 at 09:49:47AM +0100, Benoit Fouet wrote:
> > Rich Felker wrote:
> > > On Wed, Jan 02, 2008 at 07:53:12PM +0100, diego wrote:
> > >   
> > >> Log:
> > >> Merge double-nested if into && condition.
> > >> patch by Ronald S. Bultje, rsbultje gmail com
> > >>
> > >> --- trunk/libavformat/rmdec.c	(original)
> > >> +++ trunk/libavformat/rmdec.c	Wed Jan  2 19:53:12 2008
> > >> @@ -716,10 +716,8 @@ resync:
> > >>  
> > >> -        if(flags&2){
> > >> -            if((seq&0x7F) == 1)
> > >> +        if(flags&2 && (seq&0x7F) == 1)
> > >>     
> > >
> > > I would be a lot happier with some extra () around the leftmost
> > > subexpression..
> > 
> > i think the way it is written makes reader understand how it should be
> > read, without adding some superfluous parentheses...
> 
> But IMHO at a slightly higher risk of someone breaking it with some future change,
> so I agree with Rich though I don't care much.

Parentheses added.

Diego




More information about the ffmpeg-cvslog mailing list