[FFmpeg-cvslog] r11621 - trunk/libavformat/mov.c

Michael Niedermayer michaelni
Sun Jan 27 18:59:09 CET 2008


On Sun, Jan 27, 2008 at 03:38:24PM +0100, Baptiste Coudurier wrote:
> Hi,
> 
> michael wrote:
> > Author: michael
> > Date: Sat Jan 26 20:50:04 2008
> > New Revision: 11621
> > 
> > Log:
> > Select non jpeg if there are multiple substreams.
> > 
> > 
> > Modified:
> >    trunk/libavformat/mov.c
> > 
> > Modified: trunk/libavformat/mov.c
> > ==============================================================================
> > --- trunk/libavformat/mov.c	(original)
> > +++ trunk/libavformat/mov.c	Sat Jan 26 20:50:04 2008
> > @@ -600,8 +600,10 @@ static int mov_read_stsd(MOVContext *c, 
> >          get_be16(pb); /* reserved */
> >          get_be16(pb); /* index */
> >  
> > -        if (st->codec->codec_tag) {
> > -            /* multiple fourcc, just skip for now */
> > +        if (st->codec->codec_tag && st->codec->codec_tag != MKTAG('j', 'p', 'e', 'g')) {
> > +            /* multiple fourcc, we skip jpeg, this isnt correct, we should export it as
> > +               seperate AVStream but this needs a few changes in the mov demuxer, patch
> > +               welcome */
> >              url_fskip(pb, size - (url_ftell(pb) - start_pos));
> >              continue;
> >          }
> 
> This is hackish, 

yes i know


> and Im against it. 

> You will have to add all image types
> (png and so on). 

yes i will when i stumble across samples


> The proper solution must be implemented, 

well a lot of things must be implemented, now if we had the manpower
time, motivation, ...


> and adding
> hacks won't help.

that is the part i strongly disagree with
it does help alot until (if ever) the correct solution is implemented
and its a very small isolated change, the correct solution requires large
changes in the mov demuxer and in ffmpeg
correct is to export the individual streams as seperate AVStreams, export
their relation in some not yet existing API and then use the not yet in
svn avfilter to merge them after deocoding, this also would solve the croping
width/height in the mov header issue, that as well could be taken care of in
a avfilter

keep in mind its perfectly valid to code every 3rd frames with mpeg4 and the
rest with h.264 and different resolution
quicktime supports everything you never will need and lacks support for things
you do need, simplicity and clarity being one
i could bet that the correct solution wont be implemented in the next 3 years
i dont think its justified to have many mov files unplayable until then

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080127/6e73a77b/attachment.pgp>



More information about the ffmpeg-cvslog mailing list