[FFmpeg-cvslog] r14267 - trunk/libavcodec/ra288.c

Michael Niedermayer michaelni
Sun Jul 20 01:38:13 CEST 2008


On Sat, Jul 19, 2008 at 11:12:29PM +0300, Uoti Urpala wrote:
> On Fri, 2008-07-18 at 22:20 +0200, Michael Niedermayer wrote:
> > On Fri, Jul 18, 2008 at 07:13:11PM +0300, Uoti Urpala wrote:
> > > > As a sideeffect that would also work quite well with the existing messages
> > > > while existing messages would not be compatible with "the kernel way"
> > > 
> > > You could create a script that would create acceptable messages for some
> > > subset of commits. 
> > 
> > "acceptable" by what standards? by yours?
> 
> Any script is likely to either miss needed information or add
> significant clutter to some messages.

So you suggest that we add the clutter by hand to every single message ...


[...]
> 
> > > There are also some smaller problems like text layout (if
> > > you can't see how much space the automatic information part used when
> > > writing the message).
> > 
> > theres various information like the commiter name, revission number, date
> > number of lines changed ...
> > combining these in a vissually clean way is the job of the frontend, an
> > additional word for the module is not particularly hard to add in there.
> > (as can be seen by my script)
> 
> All those others are optional information and have an obvious way to
> show the value in the most efficient manner when they're needed. A
> frontend cannot know what is the most efficient way to give enough
> context to allow understanding a commit message that's missing needed
> information. Your script didn't do a particularly good job in even the
> simple cases. It produced for example
> M format/rtpdec.c  M format/rtpenc.c
> That already takes so much space that it's hard to meaningfully describe
> the commit on one line.
> The "RTP: " in the original gave enough information about the changed
> files.

Well, to me "M format/rtpdec.c  M format/rtpenc.c" is a lot more usefull
than "RTP:"
The first tells me that the commit did change both and the author did not
forget one of them. The second does not. And i honestly do not care if the
messages take 1 or 2 lines. I rather like to have all information which _I_
need there.
People who do not want the file list dont have to view it, svn supports
both variants and i suspect git as well.


[...]
> > > > > If you want to create a script to start your editor with "ra288:"
> > > > > already filled in when you start writing a commit message feel free to
> > > > > do so. 
> > > > 
> > > > > But trying to automatically fill it in later with no human check
> > > > > of the result doesn't work well.
> > > > 
> > > > No? Could you mail me your paper with the proofs and extensive tests,
> > > > i seem to be unable to find it on citeseer.
> > > 
> > > This is again such a stupid "argument" that I wonder why you posted it
> > > at all. Obviously nobody has written anything with "proofs and extensive
> > > tests" (and a strict "proof" of something being impractical would be
> > > hard in general).
> > 
> > Well you make claims as if everything was fact. While really you are just
> > guessing wildly and leaning toward what best fits your current agenda.
> > The english language has words for expressing ones lack of certainity and
> > knowledge.
> 
> I don't feel a need to express uncertainty when I say that adding
> missing information to log messages with your own custom scripts is not
> a practical solution.

Your claim was not at all limited to any scripts, neither custom ones and
least, ones written by me.


[...]

> 
> > Third, I did post a one line script, showing how to add the filenames
> > cleanly to the svn log output.
> 
> Which didn't give a particularly good result.

Thank you for your personal (and always trollish) oppinion.
The output of the script is frankly alot more usefull to me than what
has been proposed, that is no files and some human written module prefixes.

Now please understand that the ffmpeg project will continue to format its
commit messages as the majority of its developers likes best and which is
most usefull to us. Iam sorry if that displeases you, or even if it makes
your head explode with a division by zero due to it contradicting your
equality axiom of "personal oppinion" == "ultimate truth".

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080720/df980eb8/attachment.pgp>



More information about the ffmpeg-cvslog mailing list