[FFmpeg-cvslog] r14362 - trunk/libavcodec/ra288.c

[Vitor Sessak]

Reimar D?ffinger wrote:
> Hello,
> On Thu, Jul 24, 2008 at 06:07:50AM +0200, vitor wrote:
>> Author: vitor
>> Date: Thu Jul 24 06:07:50 2008
>> New Revision: 14362
>>
>> Log:
>> Follow FFmpeg convention of returning negative values on error in eval_lpc_coeffs()
> 
> Not that I want to complain, but I do not consider it a convention for
> internal functions that do not need to return any error codes.
> At least I will stay with 0/1 where it does not cause problems because
> it IMO results in more readable conditions...

I've had it pointed out once in a review (I think it was of 
graphparser.{c,h})...

-Vitor