[FFmpeg-cvslog] r13643 - in trunk: libavcodec/mpegvideo_parser.c tests/seek.regression.ref

[Michael Niedermayer]

On Tue, Jun 03, 2008 at 05:33:59AM +0100, M?ns Rullg?rd wrote:
> michael <subversion at mplayerhq.hu> writes:
> 
> > Author: michael
> > Date: Tue Jun  3 04:43:17 2008
> > New Revision: 13643
> >
> > Log:
> > In mpeg1/2 timestamps (against all logic) are associated with
> > picture start codes and not with access units.
> 
> The change may be valid, but this description doesn't make sense.
> This is what the spec says:
> 
>   For ITU-T Rec. H.262 | ISO/IEC 13818-2 video, if a PTS is present in
>   a PES packet header, it shall refer to the access unit containing
>   the first picture start code that commences in this PES packet. A
>   picture start code commences in a PES packet if the first byte of
>   the picture start code is present in the PES packet.
> 
> In other words, the access unit is defined as containing the picture
> start code, and I can't think of any other sane way of defining it.

H.264 in H.222 defines it as the first access unit that commences in the
PES packet. (which is IMHO more sane)

anyway ill try to improve the commit message tomorrow

PS: i think our PS/TS muxers handle the timestamp association in the
access unit (h.264) way instead of picture start code (mpeg1/2) way
for mpeg1/2.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080604/8a303e29/attachment.pgp>