[FFmpeg-cvslog] r13859 - trunk/ffserver.c

Baptiste Coudurier baptiste.coudurier
Sun Jun 22 11:48:51 CEST 2008


Hi,

Stefano Sabatini wrote:
>> [...]
>>  
>> @@ -4446,16 +4463,6 @@ int main(int argc, char **argv)
>>  
>>      av_init_random(av_gettime() + (getpid() << 16), &random_state);
>>  
>> -    /* address on which the server will handle HTTP connections */
>> -    my_http_addr.sin_family = AF_INET;
>> -    my_http_addr.sin_port = htons (8080);
>> -    my_http_addr.sin_addr.s_addr = htonl (INADDR_ANY);
>> -
>> -    /* address on which the server will handle RTSP connections */
>> -    my_rtsp_addr.sin_family = AF_INET;
>> -    my_rtsp_addr.sin_port = htons (5454);
>> -    my_rtsp_addr.sin_addr.s_addr = htonl (INADDR_ANY);
>> -
>>      nb_max_connections = 5;
>>      max_bandwidth = 1000;
>>      first_stream = NULL;
> 
> Hi, in this way we don't have anymore default settings for HTTP and
> RTSP ports.

Yes, this is intended.

> I suggest to keep the above lines, also a new option in the
> configuration file (RTSPPort?) would be a good idea.

RTSPPort option already exists.

> In this case I also suggest to change the Port option name to
> HTTPPort.

I don't really see the use, option has been there for a long time, and
works.

> Or if you don't want RTSP or HTTP enabled by default

I want a way to disable RSTP or HTTP, this is IMHO the simplest and
cleanest way.

> we can still
> leave them unspecified, then the user will have to specify the ports
> in the configuration file, otherwise the corresponding services won't
> be enabled.
> 

Exactly, that's the way it should work IMHO: no port specified -> disabled.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA




More information about the ffmpeg-cvslog mailing list