[FFmpeg-cvslog] r13901 - trunk/ffserver.c

[Baptiste Coudurier]

Hi Luca,

Luca Abeni wrote:
> Hi,
> 
> bcoudurier wrote:
>> Author: bcoudurier Date: Mon Jun 23 04:41:06 2008 New Revision:
>> 13901
>> 
>> Log: simplify
>> 
>> Modified: trunk/ffserver.c
>> 
>> Modified: trunk/ffserver.c 
>> ==============================================================================
>>  --- trunk/ffserver.c	(original) +++ trunk/ffserver.c	Mon Jun 23
>> 04:41:06 2008 @@ -2159,7 +2159,8 @@ static int
>> http_prepare_data(HTTPContext } } else { AVCodecContext *codec; - +
>> AVStream *ist = c->fmt_in->streams[source_index]; +
>> AVStream *ost = ctx->streams[pkt.stream_index];
> [...]
> 
> This looks wrong, because ctx seems to be used before setting it... 
> ffserver is currently segfaulting when streaming RTP, as follows: 
> FFserver version git-b22a95a, Copyright (c) 2000-2008 Fabrice
> Bellard, et al. configuration: libavutil version: 49.7.0 libavcodec
> version: 51.57.2 libavformat version: 52.16.0 libavdevice version:
> 52.0.0 built on Jun 23 2008 08:38:02, gcc: 4.2.3 (Ubuntu
> 4.2.3-2ubuntu7) Mon Jun 23 09:25:46 2008 ffserver started. Mon Jun 23
> 09:25:50 2008 127.0.0.1:57242 - - "PLAY test1-rtsp.mpg/streamid=0
> RTP/UDP" Mon Jun 23 09:25:50 2008 127.0.0.1:48054 - - "PLAY
> test1-rtsp.mpg/streamid=1 RTP/UDP"
> 
> Program received signal SIGSEGV, Segmentation fault. http_server ()
> at /home/luca/src/Video/ffmpeg/ffserver.c:2165 2165
> ost = ctx->streams[pkt.stream_index]; (gdb) bt #0  http_server () at
> /home/luca/src/Video/ffmpeg/ffserver.c:2165 #1  0x08065192 in main
> (argc=Cannot access memory at address 0x0 ) at
> /home/luca/src/Video/ffmpeg/ffserver.c:4527
> 
> 
> You can reproduce the crash in the following way: 1) add RTSPPort
> 5454 in ffserver.conf 2) uncomment the <Stream test1-rtsp.mpg> Format
> rtp [...] entry, and set File "<path to an mpeg file>" 3) Start
> ffserver, and run "vlc rtsp://127.0.0.1:5454/test1-rtsp.mpg" (you can
> use ffplay if you want).
> 

Yes, sorry, I overlooked the code. Should be fixed now. Btw Im happy
that you actually test the code, don't hesitate to report problems, and
report the better stability too ;)


-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA