[FFmpeg-cvslog] r12444 - trunk/configure

Måns Rullgård mans
Sat Mar 15 13:27:28 CET 2008


diego <subversion at mplayerhq.hu> writes:

> Author: diego
> Date: Sat Mar 15 10:45:06 2008
> New Revision: 12444
>
> Log:
> cosmetics: Reformat Apple cc check.
>
> Modified:
>    trunk/configure
>
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	(original)
> +++ trunk/configure	Sat Mar 15 10:45:06 2008
> @@ -1532,9 +1532,11 @@ fi
>
>  # AltiVec flags: The FSF version of GCC differs from the Apple version
>  if enabled altivec; then
> -    test -n "`$cc -v 2>&1 | grep version | grep Apple`" &&
> -        add_cflags "-faltivec" ||
> +    if test -n "`$cc -v 2>&1 | grep version | grep Apple`"; then

Tests like this should use grep -q.

> +        add_cflags "-faltivec"
> +    else
>          add_cflags "-maltivec -mabi=altivec"
> +    fi

Wouldn't it be better to check which flags are actually supported by
the compiler?  Theoretically, Apple could some day release a fixed
version.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-cvslog mailing list