[FFmpeg-cvslog] r12454 - trunk/configure

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Mar 15, 2008 at 08:24:08PM +0100, mru wrote:
>> 
>> Log:
>> fix DEPEND_CMD for out of tree builds
>
> Thanks a bundle.  I knew this was broken but did not get around to
> fixing it yet...
>
>> --- trunk/configure	(original)
>> +++ trunk/configure	Sat Mar 15 20:24:08 2008
>> @@ -935,7 +935,7 @@ SLIBNAME_WITH_MAJOR='$(SLIBNAME).$(LIBMA
>>  
>>  # gcc stupidly only outputs the basename of targets with -MM
>> -DEPEND_CMD='$(CC) -MM $(CFLAGS) $(filter-out %.h,$^) | sed "s,[0-9a-z._-]*: \([a-z0-9]*/\).*,\1&,"'
>> +DEPEND_CMD='$(CC) -MM $(CFLAGS) $(filter-out %.h,$^) | sed "s,[0-9a-z._-]*: \($(SRC_DIR)/\)*\([a-z0-9]*/\)[^/]* ,\2&,"'
>
> Hmm, why \2?  \1 is unused, so
>
> sed "s,[0-9a-z._-]*: $(SRC_DIR)/)*\([a-z0-9]*/\)[^/]* ,\1&,"
>
> should work as well, should it not?

The source dir may or may not be present, so a \(\) pair is needed to
make it optional.  We don't care what it is, but sed still assigns \1
to it (for obvious reasons).

>>  VHOOKDEPEND_CMD='$(CC) -MM $(VHOOKCFLAGS) $(filter-out %.h,$^) | sed "s,^\([a-z]\),vhook/\1,"'
>
> Do vhookdeps work out of tree?

It doesn't work at all, because you've made a typo.  I'll leave it to
you to fix it.  Hint: it broke when you moved the setting to configure.

-- 
M?ns Rullg?rd
mans at mansr.com