[FFmpeg-cvslog] r12469 - trunk/configure

Diego Biurrun diego
Mon Mar 17 10:44:05 CET 2008


On Mon, Mar 17, 2008 at 09:27:18AM +0000, M?ns Rullg?rd wrote:
> diego <subversion at mplayerhq.hu> writes:
> 
> > Log:
> > Add -q to grep invocation where appropriate.
> 
> And break each check in the process ;-)

No surprises there, I seem to be on a mad Cola chase this week.  At
least I finally got the depend stuff right after what felt like 100
iterations...

> > @@ -1170,7 +1170,7 @@ case $targetos in
> >          # no need for libm, but the inet stuff
> >          # Check for BONE
> >          # XXX: actually should check for NOT net_server
> > -        if (echo $BEINCLUDES|grep 'headers/be/bone' >/dev/null); then
> > +        if (echo $BEINCLUDES | grep -q 'headers/be/bone'); then
> 
> Drop the ().  No need to invoke a subshell here.

I had wondered about the subshell there myself.  I didn't add it, but
it's gone now.

> That xlc checks should be done once, storing the result in a
> variable.  I hadn't noticed this duplication before.

Feel free to fix it ;-p

I fixed all the other issues.

Diego




More information about the ffmpeg-cvslog mailing list