[FFmpeg-cvslog] r15829 - trunk/libavformat/matroskadec.c

[Michael Niedermayer]

On Sat, Nov 15, 2008 at 11:29:02PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Sat, Nov 15, 2008 at 04:34:51PM +0100, aurel wrote:
> >> Author: aurel
> >> Date: Sat Nov 15 16:34:51 2008
> >> New Revision: 15829
> >> 
> >> Log:
> >> matroskadec: fix index timestamps for some broken files
> >> fix issue697
> > [...]
> >> @@ -1369,6 +1370,11 @@ static int matroska_read_header(AVFormat
> >>  
> >>      index_list = &matroska->index;
> >>      index = index_list->elem;
> >> +    if (index_list->nb_elem
> >> +        && index[0].time > 100000000000000/matroska->time_scale) {
> >
> > doesnt the constant need a LL postfix?
> 
> No, the type defaults, roughly speaking, to the smallest type which
> can represent the value.  Type suffixes are only needed to force a
> wider type, and that is not required here.

ok, my mistake,
i was confused by seeing gcc in the past say things like
"warning: integer constant is too large for ?long? type"

but it seems it does not print this anymore since we use -std=c99

considering this, we do have quite a few unneeded LL and ULL over the
source ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081116/73527cd5/attachment.pgp>