[FFmpeg-cvslog] r18617 - trunk/libavcodec/aac.c

[Michael Niedermayer]

On Sun, Apr 19, 2009 at 02:55:46AM +0200, superdump wrote:
> Author: superdump
> Date: Sun Apr 19 02:55:46 2009
> New Revision: 18617
> 
> Log:
> Remove unnecessary assignment, found by CSA.
> 
> Modified:
>    trunk/libavcodec/aac.c
> 
> Modified: trunk/libavcodec/aac.c
> ==============================================================================
> --- trunk/libavcodec/aac.c	Sun Apr 19 00:53:37 2009	(r18616)
> +++ trunk/libavcodec/aac.c	Sun Apr 19 02:55:46 2009	(r18617)
> @@ -1616,7 +1616,7 @@ static int aac_decode_frame(AVCodecConte
>      init_get_bits(&gb, buf, buf_size*8);
>  
>      if (show_bits(&gb, 12) == 0xfff) {
> -        if ((err = parse_adts_frame_header(ac, &gb)) < 0) {
> +        if (parse_adts_frame_header(ac, &gb) < 0) {
>              av_log(avccontext, AV_LOG_ERROR, "Error decoding AAC frame header.\n");
>              return -1;
>          }

withot looking at the code id say

return err would be more correct

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090419/53892cfe/attachment.pgp>