[FFmpeg-cvslog] r20725 - in trunk/libavcodec: h263.c mpegvideo.h mpegvideo_enc.c

[Diego Biurrun]

On Thu, Dec 24, 2009 at 01:49:08PM +0100, Adrian Stutz wrote:
> >
> > Log:
> > Move ff_init_qscale_tab() from h263.c to mpegvideo, the function is not h263 specific.
> >
> > Modified:
> >    trunk/libavcodec/h263.c
> >    trunk/libavcodec/mpegvideo.h
> >    trunk/libavcodec/mpegvideo_enc.c
> 
> This broke compiling for me on OSX with the following error:
> > Undefined symbols:
> >   "_ff_init_qscale_tab", referenced from:
> >       _ff_clean_h263_qscales in h263.o
> > ld: symbol(s) not found
> > collect2: ld returned 1 exit status
> > make: *** [libavcodec.52.dylib] Error 1
> 
> These are my configure options:
> ./configure --enable-gpl --enable-shared --disable-static
> --disable-ffmpeg --disable-ffserver --enable-pthreads
> --disable-devices --disable-encoders --disable-muxers
> --disable-network --enable-postproc --enable-encoder=png
> 
> Reverting the commit made the error go away.

The problem is that h263.c now depends on mpegvideo_enc.c.  This is not good.
The code should be moved somewhere else that is not encoder-specific.

Michael, why did you move ff_init_qscale_tab at all, it is only used in
h263.c ...

Diego