[FFmpeg-cvslog] r28500 - trunk/libswscale/swscale-example.c

[Diego Biurrun]

On Mon, Feb 09, 2009 at 09:11:18PM +0100, Michael Niedermayer wrote:
> On Mon, Feb 09, 2009 at 09:00:02PM +0100, Diego Biurrun wrote:
> > On Mon, Feb 09, 2009 at 08:53:27PM +0100, Michael Niedermayer wrote:
> > > On Mon, Feb 09, 2009 at 07:04:19PM +0100, diego wrote:
> > > > 
> > > > Log:
> > > > Add config.h #include for ARCH_X86 definition.
> > > 
> > > config.h is not a public header there is no way how swscale-example could
> > > include it.
> > > Please keep in mind this is a example on how people should use swscale from
> > > their code, you wouldnt want them to include our config.h would you?
> > 
> > Unfortunately this example program was broken in multiple ways.  I fixed
> > compilation so that at least 'make tests' can run, but yes, it still has
> > issues.  It contains
> > 
> >   #if ARCH_X86
> > 
> > which implicitly relies on config.h being available.  Otherwise this
> > becomes an '#if 0' in all cases.
> 
> Please add a comment that makes it clear that #including config.h is not
> acceptable for applications

I will in a moment.

Diego