[FFmpeg-cvslog] r17252 - trunk/libavcodec/xvmc.h

[Michael Niedermayer]

On Sat, Feb 14, 2009 at 07:06:06PM +0100, iive wrote:
> Author: iive
> Date: Sat Feb 14 19:06:05 2009
> New Revision: 17252
> 
> Log:
> clarify xvmc struct fields usage distribution (internal communication)
> 
> Modified:
>    trunk/libavcodec/xvmc.h
> 
> Modified: trunk/libavcodec/xvmc.h
> ==============================================================================
> --- trunk/libavcodec/xvmc.h	Sat Feb 14 18:56:51 2009	(r17251)
> +++ trunk/libavcodec/xvmc.h	Sat Feb 14 19:06:05 2009	(r17252)
> @@ -43,7 +43,7 @@
>  #endif
>  
>  struct xvmc_render_state {
> -/**  these are not changed by the decoder! */
> +/** set by calling application */
>  //@{
>      int             magic;              ///< used as check for memory corruption by regular pixel routines
>  

some fields in these are set by the decoder as well

[...]
> @@ -69,7 +69,7 @@ struct xvmc_render_state {
>      unsigned int display_flags;     ///<1,2 or 1+2 fields for XvMCPutSurface
>  //}@
>  
> -/** these are for internal communication */
> +/** modified by calling application and the decoder */
>  //@{
>      int state;                      ///<0 - free, 1 - waiting to display, 2 - waiting for prediction
>      int start_mv_blocks_num;        ///<offset in the array for the current slice, updated by vo

This is not true as a grep will tell you not all these are modified by
both

due to these, no points, try again, points still unclaimed



> @@ -77,7 +77,7 @@ struct xvmc_render_state {
>  
>      int next_free_data_block_num;   ///<used in add_mv_block, pointer to next free block
>  //}@
> -/**extensions*/
> +/** extensions */
>  //@{
>      void * p_osd_target_surface_render; ///<pointer to the surface where subpicture is rendered
>  //}@

cosmetics, you are lucky that there is no penalty for that

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090214/e8aa6d72/attachment.pgp>