[FFmpeg-cvslog] r17233 - trunk/libavcodec/mpegvideo_xvmc.c

Diego Biurrun diego
Sun Feb 15 17:14:20 CET 2009


On Sat, Feb 14, 2009 at 07:37:58PM +0100, Diego Biurrun wrote:
> On Sat, Feb 14, 2009 at 07:26:30PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 14, 2009 at 05:05:36PM +0100, diego wrote:
> > > 
> > > Log:
> > > whitespace cosmetics: Fix indentation depth.
> > 
> > +2 for "fix all the not a multiple by 4 indention"
> > +2 for "indent all the function local variables like the code following them"
> > but i like to protest mildly against merging these 2 in a single commit and
> > while i think a penalty of 10 points is too bad i do subtract you 1 for
> > not commiting these seperately thus
> > -1
> 
> Umm, I'd like to protest here.  The commit does what the log message says
> and splitting this into two steps is overkill IMO.

I would still like to protest, this commit does exactly what the log
message says it does and it's silly to split it up further.  It would
just become "reindent 10 lines" and "reindent another 10 lines" in some
other place of the file.

Diego




More information about the ffmpeg-cvslog mailing list