[FFmpeg-cvslog] r17315 - trunk/libavcodec/mpegvideo_xvmc.c
Sun Feb 15 21:49:52 CET 2009
On Sun, Feb 15, 2009 at 09:48:45PM +0100, Diego Biurrun wrote:
> On Sun, Feb 15, 2009 at 10:03:48AM +0100, iive wrote:
> > Log:
> > Proper condition in xvmc decode mb.
> > The old one would try to use mv blocks that are written outside their buffer,
> > in case of unhandled error.
> > --- trunk/libavcodec/mpegvideo_xvmc.c Sun Feb 15 09:42:11 2009 (r17314)
> > +++ trunk/libavcodec/mpegvideo_xvmc.c Sun Feb 15 10:03:47 2009 (r17315)
> > @@ -297,6 +297,6 @@ void ff_xvmc_decode_mb(MpegEncContext *s
> > - if (render->filled_mv_blocks_num >= render->total_number_of_mv_blocks)
> > + if (render->filled_mv_blocks_num == render->total_number_of_mv_blocks)
> > ff_draw_horiz_band(s, 0, 0);
> Directly above you have
> assert(render->filled_mv_blocks_num <= render->total_number_of_mv_blocks);
> so both conditions share the == case. This cannot be right.
Should the assert be < instead of <= ?
More information about the ffmpeg-cvslog