[FFmpeg-cvslog] r17404 - trunk/libavcodec/mpegvideo_xvmc.c
Wed Feb 18 19:21:44 CET 2009
Ivan Kalvachev <ikalvachev at gmail.com> writes:
> On 2/18/09, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Wed, Feb 18, 2009 at 12:51:28AM +0100, diego wrote:
>>> Author: diego
>>> Date: Wed Feb 18 00:51:28 2009
>>> New Revision: 17404
>>> Replace sizeof(short) by the more robust sizeof(*s->pblocks[i]) in memset
>>> memcpy calls. s->pblocks is the element actually being handled.
>> ok +2 for you
>> diego 19
>> ivan 20.5
> That's actually wrong. XvMC defines block data as short
> and this is how it is in the xvmc structure.
> pblocks points into the data array so sizeof(short) is the correct way to use
The change is still correct, even if the type is unlikely to ever change.
> Now, making xvmc work when DCTELEM is not short, is interesting task.
> But for now there is no reason for me to implement it.
That is an entirely unrelated aspect.
mans at mansr.com
More information about the ffmpeg-cvslog