[FFmpeg-cvslog] r17404 - trunk/libavcodec/mpegvideo_xvmc.c

[Michael Niedermayer]

On Sat, Feb 21, 2009 at 10:34:26PM +0200, Ivan Kalvachev wrote:
> On 2/18/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Feb 18, 2009 at 08:11:29PM +0200, Ivan Kalvachev wrote:
> >> On 2/18/09, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Wed, Feb 18, 2009 at 12:51:28AM +0100, diego wrote:
> >> >> Author: diego
> >> >> Date: Wed Feb 18 00:51:28 2009
> >> >> New Revision: 17404
> >> >>
> >> >> Log:
> >> >> Replace sizeof(short) by the more robust sizeof(*s->pblocks[i]) in
> >> >> memset
> >> >> and
> >> >> memcpy calls.  s->pblocks is the element actually being handled.
> >> >
> >> > ok +2 for you
> >> >
> >> > diego 19
> >> > ivan 20.5
> >>
> >> That's actually wrong. XvMC defines block data as short
> >
> > its not wrong, the type of pblocks is wrong, it should be DCTELEM
> > well actually a array of 12 pointers to arrays of 64 DCTELEM
> > then it would be sizeof(*s->pblocks[i]) instead of sizeof(*s->pblocks[i])*64
> 
> Actually this is exactly what I thought that this task should do.
> 
> I've attached a patch that implements it, would you review it and
> tell me if it is ok to commit. I couldn't decide myself
> if memset/memcpy should take *s->pblock[i] or just s->pblock[i],
> both give same pointer value.

it has to be * for the sizeof if iam not mistaken, for the case where
the size doesnt matter either should do.

and the patch looks ok after a quick look

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090222/d9bfe814/attachment.pgp>