[FFmpeg-cvslog] r16425 - in trunk: libavcodec/Makefile libavcodec/avcodec.h libavcodec/metadata.c libavcodec/metadata.h libavformat/Makefile libavformat/avformat.h libavformat/metadata.c libavformat/metadata.h

[Michael Niedermayer]

On Sun, Jan 04, 2009 at 09:37:57PM +0100, Diego Biurrun wrote:
> On Sun, Jan 04, 2009 at 07:58:49PM +0100, michael wrote:
> > 
> > Log:
> > Move metadata API from avcodec to avformat.
> 
> Sorry to be blunt, but what nonsense is this?
> 
> In one commit you add this to libavcodec, in the next you move
> it to libavformat.  What was this good for apart from commit
> spam?

let me explain

1. I post the patch
2. aurel suggest that avformat is better and "...but the core API
    could probably already be commited (with no version bump, no
    (de)muxer change and no ffmpeg/ffplay change) so that we can
    improve it."
3. i say i dont mind to move it there if he prefers, and considering no
   significant issues seem to remain and that aurel was in favor of
   commiting the code as well, i say i will commit soon
4. i commit
5. aurel says he prefers it in avformat
6. i move it to avformat

i now see that aurel wanted me to not commit avi* yet, well i overread
that one though i think commiting it was better anyway.
we should move forward not waste time with inventing complex bandaids,
to patch up some temporary loss of functionality.
Or in other words IMHO energy should be used to update (de)muxers to the
new API instead of finding some hacks that allow old and new to pass
metadata between each other.

And on topic, as you can see from the sequence of events this was a
unfortunate sideeffect and not planned

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090104/28d6ed38/attachment.pgp>