[FFmpeg-cvslog] r16616 - in trunk/libavformat: avc.c avc.h flvenc.c matroskaenc.c movenc.c

Baptiste Coudurier baptiste.coudurier
Fri Jan 16 10:22:31 CET 2009


Hi Luca,

Luca Abeni wrote:
> Hi Baptiste,
> 
> Baptiste Coudurier wrote:
>> Hi guys,
>>
>> lucabe wrote:
>>> Author: lucabe
>>> Date: Thu Jan 15 15:03:07 2009
>>> New Revision: 16616
>>>
>>> Log:
>>> Do not reallocate AVPacket's data when muxing a packet
>>>
>> Argh, I just noticed a problem with the patch, this broke muxing if nal
>>  startcodes are not 4 bytes :(
> 
> Ops... Sorry about that.

Well, I didn't spot it earlier, so it's also my fault, I'd say.

>> I think this must be reverted and the other approach must be used
>> (allocating a new buffer).
>>
>> I will implement this in flv and mov muxer, I don't know much about mkv
>> muxer.
> 
> I was going to check how to revert the patch using the fancy svn
> features, but I see that you already committed something else to
> avc.{c,h}... 

Yeah, reverting in svn in a pain :(

> Should the patch still be reverted? Or should I revert only
> the part not touching avc.c? Or did you already fix the problem in the
> meanwhile?

It's ok, everything should be fine now. Thanks for caring though.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org




More information about the ffmpeg-cvslog mailing list