[FFmpeg-cvslog] r16688 - in trunk/libavformat: Makefile id3v2.c id3v2.h mp3.c mpc.c raw.c

Mike Melanson mike
Tue Jan 20 08:15:27 CET 2009


Alex Converse wrote:
> On Tue, Jan 20, 2009 at 1:41 AM, Mike Melanson <mike at multimedia.cx> wrote:
>> Alex Converse wrote:
>>> I think I see what it was. The maximum buffer size was being
>>> calculated using the post-ID3v2 start on the actual start of the
>>> buffer. Does this fix it for you?
>> Indeed, it does fix the crash.
>>
>> I'm just glad I happened to be testing some FATE ideas with such an MP3
>> tonight. So I guess I can sort of claim that FATE caught this. :)
>>
> 
> Can I go ahead and commit the fix?

Insofar as it fixes the immediate problem, I say sure, go ahead. Michael 
might have some other input on the correctness or purity of the 
solution, of course.

-- 
     -Mike Melanson




More information about the ffmpeg-cvslog mailing list