[FFmpeg-cvslog] r16717 - trunk/ffmpeg.c

[Michael Niedermayer]

On Thu, Jan 22, 2009 at 11:35:59AM -0800, Baptiste Coudurier wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> > On Thu, Jan 22, 2009 at 01:04:01PM +0100, michael wrote:
> >> Author: michael
> >> Date: Thu Jan 22 13:04:01 2009
> >> New Revision: 16717
> >>
> >> Log:
> >> Handle av_read_frame() EAGAIN return.
> > 
> > This seems to break the ffm regression test as ffmdec.c returns EAGAIN at
> > EOF which causes an infinite loop ...
> > Iam not sure how to fix this, ideas are welcome!
> 
> Yes it seems design needs to be changed:
> Add a new flag FLAG_EOF, and write a ffm packet with it in
> ffm_write_trailer, then return -1 when this packet is read.

i can but this still will make truncated ffm files lock the player
which in some cases like automated processing of files, especially
user provided ones is not good (uploading ffm to youtube ...)


> 
> Btw, what is the practical interest of return EAGAIN instead of
> continuing like flv previously did ?

none in flv :)
ive added it because i stumbled across an ancient mail from mike where he
compared lavf to xine and complained that the demuxers have to output
something and that its sometimes more natural to just output nothing.
I just used flv to test that the code works and ensure its tested by the
reression tests ...


> 
> greping EAGAIN in libavformat returns nothing related to demuxers
> 
> Also it's been some time Im thinking of adding EOS and EOF return values
> instead of return -1 (an error). What do you think about that ?

after 1sec thinking (= no thinking) it sounds like a good idea :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090122/80e52b11/attachment.pgp>